Skip to content

nixos/nvidia-container-toolkit: fix tests#426273

Merged
ConnorBaker merged 1 commit into
NixOS:masterfrom
ConnorBaker:fix/nixos-tests-nvidia-container-toolkit
Jul 18, 2025
Merged

nixos/nvidia-container-toolkit: fix tests#426273
ConnorBaker merged 1 commit into
NixOS:masterfrom
ConnorBaker:fix/nixos-tests-nvidia-container-toolkit

Conversation

@ConnorBaker
Copy link
Copy Markdown
Contributor

@ConnorBaker ConnorBaker commented Jul 18, 2025 •
edited
Loading

Big thank you to @ereslibre for fixing the tests! Originally from ConnorBaker#12.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@ConnorBaker ConnorBaker self-assigned this Jul 18, 2025
@ConnorBaker ConnorBaker added 6.topic: nvidia Nvidia-specific issues and fixes backport release-25.05 labels Jul 18, 2025
@ConnorBaker ConnorBaker mentioned this pull request Jul 18, 2025
Closed
13 tasks
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 18, 2025
@ConnorBaker
Copy link
Copy Markdown
Contributor Author

ConnorBaker commented Jul 18, 2025 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 426273 --package nixosTests.nvidia-container-toolkit
Commit: d287c86c08ded17c7cb2659bb78c477e6d2a7f58

x86_64-linux

✅ 1 test built:
  • nixosTests.nvidia-container-toolkit

aarch64-linux

✅ 1 test built:
  • nixosTests.nvidia-container-toolkit

@ConnorBaker ConnorBaker requested a review from ereslibre July 18, 2025 04:30
@nixpkgs-ci nixpkgs-ci Bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 18, 2025
ereslibre
ereslibre approved these changes Jul 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ConnorBaker!

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 18, 2025
@ConnorBaker ConnorBaker merged commit b435860 into NixOS:master Jul 18, 2025
34 of 36 checks passed
@ConnorBaker ConnorBaker deleted the fix/nixos-tests-nvidia-container-toolkit branch July 18, 2025 13:32
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci Bot commented Jul 18, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions Bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jul 18, 2025
@nixpkgs-ci nixpkgs-ci Bot mentioned this pull request Jul 18, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ereslibre ereslibre ereslibre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ConnorBaker ConnorBaker

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nvidia Nvidia-specific issues and fixes 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ConnorBaker @ereslibre